Re: [PATCH] of: Print rather than WARN'ing when overlap check fails
From: Michael Ellerman
Date: Tue Nov 10 2015 - 16:47:09 EST
On Tue, 2015-11-10 at 09:41 +0000, David Laight wrote:
> From: Michael Ellerman
> > Sent: 10 November 2015 05:09
> > __rmem_check_for_overlap() is called very early in boot, and on some
> > powerpc systems it's not safe to call WARN that early in boot.
> > If the overlap check fails the system will oops instead of printing a
> > warning. Furthermore because it's so early in boot the console is not up
> > and the user doesn't see the oops, they just get a dead system.
> Wouldn't it be better to add the required checks to WARN()?
Yes obviously it would. But that's less simple than it sounds. I'm working on
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/