Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru

From: Dmitry Krivenok
Date: Tue Nov 10 2015 - 10:05:22 EST

> Is your concern readibility or size of generated code (or both?)
> I'll look to consolidating the debug printing in next version as additional patch.

Just a minor style comment, not critical.

> If we had a longer list, I would definitely say yes. Not so sure with
> just two types. I'll take a look for the next version.

The same, just a style comment.

> list_for_each_entry(nvdimm_bus, &nvdimm_bus_list, list) {
> - if (nvdimm_bus->id == id) {
> + if (nvdimm_bus->id != id)

I noticed another minor issue. You have switched from "==" to "!="
here, but you didn't add "break" after ioctl is handled for the found

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at