Re: [PATCH 03/11] Drivers: hv: vmbus: Use the macro for comparing GUIDs

[Andy Shevchenko]

On Wed, Nov 11, 2015 at 3:59 AM, K. Y. Srinivasan <kys@xxxxxxxxxxxxx> wrote:
> Use the uuid_le_cmp() macro for comparing GUIDs.

It's not a macro as I see.

>
> Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> ---
>  drivers/hv/channel_mgmt.c |    3 +--
>  drivers/hv/vmbus_drv.c    |    4 ++--
>  2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
> index 38470aa..dc4fb0b 100644
> --- a/drivers/hv/channel_mgmt.c
> +++ b/drivers/hv/channel_mgmt.c
> @@ -408,8 +408,7 @@ static void init_vp_index(struct vmbus_channel *channel, const uuid_le *type_gui
>         struct cpumask *alloced_mask;
>
>         for (i = IDE; i < MAX_PERF_CHN; i++) {
> -               if (!memcmp(type_guid->b, &hp_devs[i].guid,
> -                                sizeof(uuid_le))) {
> +               if (!uuid_le_cmp(*type_guid, hp_devs[i].guid)) {
>                         perf_chn = true;
>                         break;
>                 }
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 7078b5f..9e0e25c 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -533,7 +533,7 @@ static const uuid_le null_guid;
>
>  static inline bool is_null_guid(const uuid_le *guid)
>  {
> -       if (memcmp(guid, &null_guid, sizeof(uuid_le)))
> +       if (uuid_le_cmp(*guid, null_guid))
>                 return false;
>         return true;
>  }
> @@ -547,7 +547,7 @@ static const struct hv_vmbus_device_id *hv_vmbus_get_id(
>                                         const uuid_le *guid)
>  {
>         for (; !is_null_guid(&id->guid); id++)
> -               if (!memcmp(&id->guid, guid, sizeof(uuid_le)))
> +               if (!uuid_le_cmp(id->guid, *guid))
>                         return id;
>
>         return NULL;
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/