Re: [PATCH 3/3] tools/vm/slabinfo: update struct slabinfo members' types
From: David Rientjes
Date: Thu Nov 12 2015 - 00:07:20 EST
On Thu, 12 Nov 2015, Sergey Senozhatsky wrote:
> > > /* Object size */
> > > - unsigned long long min_objsize = max, max_objsize = 0, avg_objsize;
> > > + unsigned int min_objsize = UINT_MAX, max_objsize = 0, avg_objsize;
> > >
> > > /* Number of partial slabs in a slabcache */
> > > unsigned long long min_partial = max, max_partial = 0,
> > avg_objsize should not be unsigned int.
> Hm. the assumption is that `avg_objsize' cannot be larger
> than `max_objsize', which is
> `int object_size;' in `struct kmem_cache' from slab_def.h
> `unsigned int object_size;' in `struct kmem_cache' from slab.h.
> avg_objsize = total_used / total_objects;
total_used and total_objects are unsigned long long. This has nothing to
do with object_size in the kernel. If you need to convert max_objsize to
be unsigned long long as well, that would be better.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/