Re: [PATCH] acpi: add support for extended IRQ to PCI link

From: Timur Tabi
Date: Thu Nov 12 2015 - 10:58:32 EST


okaya@xxxxxxxxxxxxxx wrote:
This is what it was before.

> if (acpi_irq_balance || !link->irq.active) {
>- /*
>- * Select the best IRQ. This is done in reverse to promote
>- * the use of IRQs 9, 10, 11, and >15.
>- */
>- for (i = (link->irq.possible_count - 1); i >= 0; i--) {
>- if (acpi_irq_penalty[irq] >
>- acpi_irq_penalty[link->irq.possible[i]])
>- irq = link->irq.possible[i];
I added a range check for link->irq.possible[i] and irq into this code.



This change:

- * Select the best IRQ. This is done in reverse to promote
- * the use of IRQs 9, 10, 11, and >15.
+ * Select the best IRQ. This is done in reverse to
+ * promote the use of IRQs 9, 10, 11, and >15.

is an unrelated whitespace change. It doesn't belong in this patch.

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/