[PATCH 3.2 30/60] crypto: ahash - ensure statesize is non-zero
From: Ben Hutchings
Date: Sat Nov 14 2015 - 21:08:43 EST
3.2.73-rc1 review patch. If anyone has any objections, please let me know.
From: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
commit 8996eafdcbad149ac0f772fb1649fbb75c482a6a upstream.
Unlike shash algorithms, ahash drivers must implement export
and import as their descriptors may contain hardware state and
cannot be exported as is. Unfortunately some ahash drivers did
not provide them and end up causing crashes with algif_hash.
This patch adds a check to prevent these drivers from registering
ahash algorithms until they are fixed.
Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
crypto/ahash.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
@@ -462,7 +462,8 @@ static int ahash_prepare_alg(struct ahas
struct crypto_alg *base = &alg->halg.base;
if (alg->halg.digestsize > PAGE_SIZE / 8 ||
- alg->halg.statesize > PAGE_SIZE / 8)
+ alg->halg.statesize > PAGE_SIZE / 8 ||
+ alg->halg.statesize == 0)
base->cra_type = &crypto_ahash_type;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/