Re: [PATCH, resend] scsi: advansys: fix big-endian builds
From: Geert Uytterhoeven
Date: Mon Nov 16 2015 - 13:56:13 EST
On Mon, Nov 16, 2015 at 7:20 PM, Russell King - ARM Linux
> On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote:
>> It turns out that the commit that introduced this used the cpu_to_le32()
>> incorrectly on an 8-bit field, which results in the sense_len to always
>> be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper
>> byte of the 32-bit intermediate.
> More people need to run the sparse checker with -D__CHECK_ENDIAN__ and
> have proper endian annotations?
But in this case, it shows up as a normal compiler warning on all big endian
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/