Re: [PATCH v2 0/3] nvdimm: Add an IOCTL pass thru for DSM calls
From: Dan Williams
Date: Mon Nov 16 2015 - 14:00:28 EST
On Mon, Nov 16, 2015 at 10:38 AM, Jerry Hoemann <jerry.hoemann@xxxxxxx> wrote:
> The NVDIMM code in the kernel supports an IOCTL interface to user
> space based upon the Intel Example DSM:
> This interface cannot be used by other NVDIMM DSMs that support
> incompatible functions.
> This patch set adds a generic "passthru" IOCTL interface which
> is not tied to a particular DSM.
> A new _IOC_NR ND_CMD_PASSTHRU == "100" is added for the pass thru call.
> The new data structure nd_passthru_pkg serves as a wrapper for the passthru
> calls. This wrapper supplies the data that the kernel needs to
> make the _DSM call.
> Unlike the definitions of the _DSM functions themselves, the nd_passthru_pkg
> provides the calling information (input/output sizes) in an uniform
> manner making the kernel marshaling of the arguments straight
> This shifts the marshaling burden from the kernel to the user
> space application while still permitting the kernel to internally
> call _DSM functions.
> To make the resultant kernel code easier to understand the existing
> functions acpi_nfit_ctl and __nd_ioctl were renamed to .*_intel to
> denote calling mechanism as in 4.3 tailored to the Intel Example DSM.
> New functions acpi_nfit_ctl_passthru and __nd_ioctl_passthru were
> created to supply the pass thru interface.
Let's not do the _intel vs _passthru split. I want to convert the
existing commands over to this new interface and deprecate the old
ioctl-command formats. I.e. it isn't the case that this will be a
always be a blind "passthru" mechanism, the kernel will need to crack
open this payload in some circumstances.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/