Re: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro

From: Dan Carpenter
Date: Thu Nov 19 2015 - 02:51:53 EST

On Wed, Nov 18, 2015 at 04:26:52PM +0000, Ian Abbott wrote:
> >+#define DMM32AT_AI_CFG_SCINT_10US (BIT(5) & ~BIT(4))
> >+#define DMM32AT_AI_CFG_SCINT_5US (BIT(5) | BIT(4))
> The values of DMM32AT_AI_CFG_SCINT_20US etc. are numerically
> correct, but look a bit strange. The `(BIT(5) & ~BIT(4))` looks
> especially strange and could be changed to `BIT(5)`. These are all
> really shifted 2-bit values, so perhaps the BIT() macro isn't the
> best representation.

BIT(5) & ~BIT(4) is silly. Don't do that.

The original code was fine.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at