Re: [PATCH v2 1/1] x86/platform/iosf_mbi: Remove duplicate definitions

[Thomas Gleixner]

On Wed, 11 Nov 2015, Andy Shevchenko wrote:

> The read and write opcodes are global for all units on SoC and even across
> Intel SoCs. Remove duplication of corresponding constants. At the same time
> convert all current users.
> 
> No functional change.
> 
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Anvin <hpa@xxxxxxxxx>
> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Cc: Eduardo Valentin <edubezval@xxxxxxxxx>
> Cc: Hock Leong Kweh <hock.leong.kweh@xxxxxxxxx>
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> Since v1:
> - satisfy kbuild robot
> 
>  arch/x86/include/asm/iosf_mbi.h              | 49 +++++-----------------
>  arch/x86/platform/atom/punit_atom_debug.c    |  7 +---
>  arch/x86/platform/intel-quark/imr.c          | 28 +++++--------
>  drivers/i2c/busses/i2c-designware-baytrail.c | 17 +++-----
>  drivers/powercap/intel_rapl.c                | 10 ++---
>  drivers/thermal/intel_quark_dts_thermal.c    | 61 ++++++++++++++--------------
>  drivers/thermal/intel_soc_dts_iosf.c         | 43 ++++++++++----------

Hmm. Either we get acks of all maintainers and merge it through
tip/x86/... or we do the following:

Add the new constants w/o using them in a seperate patch and ship that
linuswards now. Then the subsystem maintainers can pick the individual
patches up and after the merge window closes we remove the old
constants in one go.

Either way works for me.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/