Re: [PATCH v2 1/1] x86/platform/iosf_mbi: Remove duplicate definitions

[Andy Shevchenko]

On Wed, 2015-11-25 at 15:20 +0100, Thomas Gleixner wrote:
> On Wed, 11 Nov 2015, Andy Shevchenko wrote:
> 
> > The read and write opcodes are global for all units on SoC and even
> across
> > Intel SoCs. Remove duplication of corresponding constants. At the
> same time
> > convert all current users.
> > 
> > No functional change.
> > 
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Peter Anvin <hpa@xxxxxxxxx>
> > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> > Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> > Cc: Eduardo Valentin <edubezval@xxxxxxxxx>
> > Cc: Hock Leong Kweh <hock.leong.kweh@xxxxxxxxx>

Eduardo, Rui, can you provide your ACKs or comments about the patch?

> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> > Since v1:
> > - satisfy kbuild robot
> > 
> >Â arch/x86/include/asm/iosf_mbi.hÂÂÂÂÂÂÂÂÂÂÂÂÂ | 49 +++++-----------
> ------
> >Â arch/x86/platform/atom/punit_atom_debug.cÂÂÂ |Â 7 +---
> >Â arch/x86/platform/intel-quark/imr.cÂÂÂÂÂÂÂÂÂ | 28 +++++--------
> >Â drivers/i2c/busses/i2c-designware-baytrail.c | 17 +++-----
> >Â drivers/powercap/intel_rapl.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 10 ++---
> >Â drivers/thermal/intel_quark_dts_thermal.cÂÂÂ | 61 ++++++++++++++
> --------------
> >Â drivers/thermal/intel_soc_dts_iosf.cÂÂÂÂÂÂÂÂ | 43 ++++++++++----
> ------
> 
> Hmm. Either we get acks of all maintainers and merge it through
> tip/x86/... 

I prefer this way becauseâ

> or we do the following:
> 
> Add the new constants w/o using them in a seperate patch and ship
> that
> linuswards now. Then the subsystem maintainers can pick the
> individual
> patches up and after the merge window closes we remove the old
> constants in one go.
> 
> Either way works for me.

âwe are working on another fix which is based also on this patch. Can
you provide your ACK if you are okay with the changes to arch/x86 ?

> 
> Thanks,
> 
> ÂÂÂÂÂÂÂÂtglx
> 
> 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/