Re: [PATCH] mm/memcontrol.c: use list_{first,next}_entry
From: Johannes Weiner
Date: Thu Dec 03 2015 - 14:28:08 EST
On Thu, Dec 03, 2015 at 05:27:18PM +0100, Michal Hocko wrote:
> On Thu 03-12-15 22:16:55, Geliang Tang wrote:
> > To make the intention clearer, use list_{first,next}_entry instead
> > of list_entry.
>
> Does this really help readability? This function simply uncharges the
> given list of pages. Why cannot we simply use list_for_each_entry
> instead...
You asked the same thing when reviewing the patch for the first
time. :-) I think it's time to add a comment.