Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

[Saurabh Sengar]

On 12 December 2015 at 14:10, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
>> On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
>> > This patch does the following:
>> > * changed the complicated if statements to simple case statements
>> > * in case of E_DEFAULT, no need to return error as ERESTART,
>> > because this is the user asked for. Hence function should return success.
>> > * ret variable is 0 always, hence removed it.
>> > * removed one ternary operator, as it was always returning the status value only,
>> > and hence removed the status variable too
>>
>> That becomes 4 different changes. Please break them into separate
>> patches.
>
> It's cleaning up one function so you could argue that it's just one
> thing.  Sometimes it's actually harder to review when a patch is broken
> into ultra tiny junks.
yes Dan, this is my point too.
I was planning to cleanup many function in speakup.
If I will be breakup in to such a small chunk, it will problem for both of us.
The best I can do is to hide the details in description and just say
clanup there.
I am open to suggestions.


Regards,
Saurabh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/