Re: [PATCH] sched/fair: fix mul overflow on 32-bit systems

From: bsegall
Date: Mon Dec 14 2015 - 12:52:07 EST


Morten Rasmussen <morten.rasmussen@xxxxxxx> writes:

> On Fri, Dec 11, 2015 at 11:18:56AM -0800, bsegall@xxxxxxxxxx wrote:
>> So uh yeah, my initial impression is "rip it out", but if being
>> immediately-correct is important in the case of one task being most of
>> the utilization, rather than when it is more evenly distributed, it
>> would probably make more sense to instead put in the add-on-enqueue
>> code.
>
> I would prefer if stayed in. There are several patch sets posted for
> review that use util_avg.


Yeah, I missed the attach call on enqueue, which means my argument is
basically invalid, as the code is sensible enough at the moment ("rip it
out" was meant to refer only to the remove-on-migrate, not the whole
util_avg).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/