RE: [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing initializer

[Dexuan Cui]

> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Tuesday, December 15, 2015 3:21
> To: tj@xxxxxxxxxx
> Cc: Dexuan Cui <decui@xxxxxxxxxxxxx>; pablo@xxxxxxxxxxxxx; kaber@xxxxxxxxx;
> kadlec@xxxxxxxxxxxxxxxxx; daniel@xxxxxxxxxxxxx; daniel.wagner@xxxxxxxxxxxx;
> nhorman@xxxxxxxxxxxxx; lizefan@xxxxxxxxxx; hannes@xxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; netfilter-devel@xxxxxxxxxxxxxxx;
> coreteam@xxxxxxxxxxxxx; cgroups@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; kernel-team@xxxxxx; ninasc@xxxxxx
> Subject: Re: [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing
> initializer
> 
> From: Tejun Heo <tj@xxxxxxxxxx>
> Date: Mon, 14 Dec 2015 11:24:06 -0500
> 
> > bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup") added global
> > spinlock cgroup_sk_update_lock but erroneously skipped initializer
> > leading to uninitialized spinlock warning.  Fix it by using
> > DEFINE_SPINLOCK().
> >
> > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> > Reported-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> > Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")
> 
> Applied, thanks.

Thanks! I can confirm it fixed the issue.

Thanks,
-- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/