Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count for F81504/508/512

[Peter Hung]

Hi Greg,

Andy Shevchenko æ 2015/12/13 äå 09:08 åé:
> First of all, maybe you can consider to split this part of the driver
> to separate one? (Like we did for 8250_mid.c). It seems 8250_pci is
> too bloated. But it's just an idea, maybe for future.

Did you have reviewed this patch? Please skip this patch if not
reviewed.

The F81504/508/512 is multi-function card. It contains
Serial/GPIO functions. It maybe enlarge the scale of 8250_pci.c and
make it less maintainable if we add GPIOLIB support into 8250_pci.c

Could I split the F81504/508/512 driver from 8250_pci.c into a
new module file and implements GPIOLIB?

Thanks
--
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/