Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events

[Jiri Olsa]

On Mon, Dec 21, 2015 at 11:26:48PM +0900, Namhyung Kim wrote:

SNIP

> +	free(str);
> +	return ret;
> +}
> +
>  static int __sort_dimension__add(struct sort_dimension *sd)
>  {
>  	if (sd->taken)
> @@ -1667,6 +1887,9 @@ static int sort_dimension__add(const char *tok,

sort_dimension__add's evlist arg could loose the '__maybe_unused' now

thanks,
jirka

>  		return 0;
>  	}
>  
> +	if (!add_dynamic_entry(evlist, tok))
> +		return 0;
> +
>  	return -ESRCH;
>  }
>  
> -- 
> 2.6.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/