Re: [RFC/PATCH] perf report: Show random usage tip on the help line

From: Namhyung Kim
Date: Tue Jan 05 2016 - 05:44:50 EST


Hi,

On Tue, Jan 05, 2016 at 02:32:47PM +0800, Wangnan (F) wrote:
>
>
> On 2016/1/5 13:36, Namhyung Kim wrote:
> >Currently perf report only shows a help message "For a higher level
> >overview, try: perf report --sort comm,dso" unconditionally (even if
> >the sort keys were used). Add more help tips and show randomly.
> >
> >Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> >---
>
> That's really funny.

Thanks for your feedback!

>
> Some inconvenience:
>
> 1. Tip is never change during one execution of 'perf report', even if
> I switch to another view using 'enter' and switch back. It should better
> if tips updated when redrawing.

Hmm.. I think it's a preference. I'd go for simplicity then. :)


>
> 2. I think add a "Tip: " prefix to the content should be better, or users
> may confuse what he/her doing causes this message

OK.

>
> 3. What about creating a tools/perf/Documentation/tips.txt and generate
> tips table dynamically?

I don't see much difference doing that. I guess most of users don't
want to go to see the documentation anyway. Do I miss something?

Btw, does anyone have some tips to add? :)

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/