Re: [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc

From: Laurent Pinchart
Date: Sun Jan 10 2016 - 20:57:33 EST


Hi Javier,

Thank you for the patch.

On Thursday 07 January 2016 15:27:15 Javier Martinez Canillas wrote:
> The v4l2_of_parse_endpoint function kernel-doc says that the return value
> is always 0. But that is not true since the function can fail and a error
> negative code is returned on failure. So correct the kernel-doc to match.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>
> drivers/media/v4l2-core/v4l2-of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-of.c
> b/drivers/media/v4l2-core/v4l2-of.c index b27cbb1f5afe..93b33681776c 100644
> --- a/drivers/media/v4l2-core/v4l2-of.c
> +++ b/drivers/media/v4l2-core/v4l2-of.c
> @@ -146,7 +146,7 @@ static void v4l2_of_parse_parallel_bus(const struct
> device_node *node, * variable without a low fixed limit. Please use
> * v4l2_of_alloc_parse_endpoint() in new drivers instead.
> *
> - * Return: 0.
> + * Return: 0 on success or a negative error code on failure.
> */
> int v4l2_of_parse_endpoint(const struct device_node *node,
> struct v4l2_of_endpoint *endpoint)

--
Regards,

Laurent Pinchart