Re: [PATCH 8/8] [media] omap3isp: Check v4l2_of_parse_endpoint() return value

From: Laurent Pinchart
Date: Sun Jan 10 2016 - 20:58:07 EST


Hi Javier,

Thank you for the patch.

On Thursday 07 January 2016 15:27:22 Javier Martinez Canillas wrote:
> The v4l2_of_parse_endpoint() function can fail so check the return value.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>
> drivers/media/platform/omap3isp/isp.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/omap3isp/isp.c
> b/drivers/media/platform/omap3isp/isp.c index 79a0b953bba3..891e54394a1c
> 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -2235,8 +2235,11 @@ static int isp_of_parse_node(struct device *dev,
> struct device_node *node, struct isp_bus_cfg *buscfg = &isd->bus;
> struct v4l2_of_endpoint vep;
> unsigned int i;
> + int ret;
>
> - v4l2_of_parse_endpoint(node, &vep);
> + ret = v4l2_of_parse_endpoint(node, &vep);
> + if (ret)
> + return ret;
>
> dev_dbg(dev, "parsing endpoint %s, interface %u\n", node->full_name,
> vep.base.port);

--
Regards,

Laurent Pinchart