Re: [PATCH 6/6] regulator: max77620: add regulator driver for max77620/max20024

From: Laxman Dewangan
Date: Mon Jan 11 2016 - 05:26:50 EST


Thanks Mark for review.

I have query in one of comment.

On Sunday 10 January 2016 06:10 PM, Mark Brown wrote:
* PGP Signed by an unknown key

On Thu, Jan 07, 2016 at 08:08:44PM +0530, Laxman Dewangan wrote:


+ np = of_get_child_by_name(pdev->dev.parent->of_node, "regulators");
+ if (!np) {
+ dev_err(&pdev->dev, "Device is not having regulators node\n");
+ return -ENODEV;
+ }
+ pdev->dev.of_node = np;
+
+ ret = of_regulator_match(&pdev->dev, np, max77620_regulator_matches,
+ ARRAY_SIZE(max77620_regulator_matches));
+ if (ret < 0) {
+ dev_err(&pdev->dev, "Parsing of regulator node failed: %d\n",
+ ret);
+ return ret;
+ }
Don't open code this, use the core support via regulators and of_match.


I did not get this point? Here I am using the of_regulator_match from core? Can you please help to explain this?