Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors

[Andy Shevchenko]

On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> This patch fixes whitespace errors reported by checkpatch to increase
> readability. Main focus is on missing spaces after commas in
> function headers and macros (like foo,bar edited to foo, bar).
> 
> Signed-off-by: Anton WÃrfel <anton.wuerfel@xxxxxx>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@xxxxxx>
> CC: linux-kernel@xxxxxxxxxxxx

Cc: looks more standard.

> --- a/drivers/tty/serial/8250/8250_accent.c
> +++ b/drivers/tty/serial/8250/8250_accent.c
> @@ -10,7 +10,7 @@
> Â#include <linux/init.h>
> Â#include <linux/serial_8250.h>
> Â
> -#define PORT(_base,_irq)				\
> +#define PORT(_base, _irq)				\
> Â	{						\
> Â		.iobase		= _base,		\
> Â		.irq		= _irq,			\
> 

While those are okay, I would suggest to make a macro in
drivers/â/8250.h one for all, something like this:

#define 8250_PORT_FLAGS(_base, _irq, _flags)
â
	.flagsÂÂÂÂÂÂÂÂÂÂ= UPF_BOOT_AUTOCONF | (_flags) \

#define 8250_PORT(_base, _irq)	8250_PORT_FLAGS(_base, _irq, 0)

And use it.

> --- a/drivers/tty/serial/8250/8250_boca.c
> +++ b/drivers/tty/serial/8250/8250_boca.c
> @@ -10,7 +10,7 @@
> Â#include <linux/init.h>
> Â#include <linux/serial_8250.h>
> Â
> -#define PORT(_base,_irq)				\
> +#define PORT(_base, _irq)				\
> Â	{						\
> Â		.iobase		= _base,		\
> Â		.irq		= _irq,			\
> 

> --- a/drivers/tty/serial/8250/8250_exar_st16c554.c
> +++ b/drivers/tty/serial/8250/8250_exar_st16c554.c
> @@ -13,7 +13,7 @@
> Â#include <linux/init.h>
> Â#include <linux/serial_8250.h>
> Â
> -#define PORT(_base,_irq)				\
> +#define PORT(_base, _irq)				\
> Â	{						\
> Â		.iobase		= _base,		\
> Â		.irq		= _irq,			\
> 

> --- a/drivers/tty/serial/8250/8250_fourport.c
> +++ b/drivers/tty/serial/8250/8250_fourport.c
> @@ -10,7 +10,7 @@
> Â#include <linux/init.h>
> Â#include <linux/serial_8250.h>
> Â
> -#define PORT(_base,_irq)						
> \
> +#define PORT(_base, _irq)						
> \
> Â	{								
> \
> Â		.iobase		= _base,			
> 	\
> Â		.irq		= _irq,				
> 	\



-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy