Re: [PATCH v4 05/13] tty: serial: 8250: Remove else after return

[Andy Shevchenko]

On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> This patch fixes checkpatch warnings about unnecessary else blocks
> after
> return statements.

> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -805,10 +805,10 @@ static int pci_netmos_9900_numports(struct
> pci_dev *dev)
> Â
> Â	pi = (c & 0xff);

And here the parens are redundant.

> Â
> -	if (pi == 2) {
> +	if (pi == 2)
> Â		return 1;
> -	} else if ((pi == 0) &&
> -			ÂÂÂ(dev->device ==
> PCI_DEVICE_ID_NETMOS_9900)) {
> +
> +	if ((pi == 0) && (dev->device == PCI_DEVICE_ID_NETMOS_9900))
> {

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy