Re: [PATCH 1/2] mm, oom: introduce oom reaper

From: Michal Hocko
Date: Tue Jan 12 2016 - 03:16:49 EST


On Mon 11-01-16 14:54:55, Andrew Morton wrote:
> On Wed, 6 Jan 2016 16:42:54 +0100 Michal Hocko <mhocko@xxxxxxxxxx> wrote:
>
> > - use subsys_initcall instead of module_init - Paul Gortmaker
>
> That's pretty much the only change between what-i-have and
> what-you-sent, so I'll just do this as a delta:

Yeah that should be the case, thanks for double checking!

> --- a/mm/oom_kill.c~mm-oom-introduce-oom-reaper-v4
> +++ a/mm/oom_kill.c
> @@ -32,12 +32,11 @@
> #include <linux/mempolicy.h>
> #include <linux/security.h>
> #include <linux/ptrace.h>
> -#include <linux/delay.h>
> #include <linux/freezer.h>
> #include <linux/ftrace.h>
> #include <linux/ratelimit.h>
> #include <linux/kthread.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>
> #include <asm/tlb.h>
> #include "internal.h"
> @@ -542,7 +541,7 @@ static int __init oom_init(void)
> }
> return 0;
> }
> -module_init(oom_init)
> +subsys_initcall(oom_init)
> #else
> static void wake_oom_reaper(struct mm_struct *mm)
> {
> _

--
Michal Hocko
SUSE Labs