Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable

[Wangnan (F)]

On 2016/1/13 18:03, Jiri Olsa wrote:
> On Wed, Jan 13, 2016 at 05:46:13PM +0800, Wangnan (F) wrote:
>
> SNIP
>
> > > I'll try to check on that.. does this patch help to improve
> > > the current speed or do you need to solve this to get substantial
> > > speedup?
> > I'm working on it. I have already done it, but still have some
> > problem. On some machine 'make_static' test target lost
> > '-liberty -lz' in its linker options. Seems something wrong in
> > this part:
> >
> > ifeq ($(feature-libbfd), 1)
> >    EXTLIBS += -lbfd
> >
> >    # call all detections now so we get correct
> >    # status in VF output
> >    $(call feature_check,liberty)
> >    $(call feature_check,liberty-z)
> >    $(call feature_check,cplus-demangle)
> >
> >    ifeq ($(feature-liberty), 1)
> >      EXTLIBS += -liberty
> >    else
> >      ifeq ($(feature-liberty-z), 1)
> >        EXTLIBS += -liberty -lz
> >      endif
> >    endif
> > endif
> IIRC we had issues with this before.. different systems
> provide those libs in different way, like:
>    2cf9040714f3 perf tools: Fix bfd dependency libraries detection
>
> you might want to check feature detection code if it gets
> built properly on your system

No this problem. There's no feature-libiberty and feature-libiberty-z in
output feature-dump file. This is the key reason.

> jirka