Re: [PATCH V2 2/6] mfd: max77620: add core driver for MAX77620/MAX20024

[Alexandre Belloni]

On 13/01/2016 at 14:30:26 +0530, Laxman Dewangan wrote :
> In my 3rd patch, I tried to align it little more where is possible. But I
> feel that all these indenting is more over individual choice. Example, I
> added one more indent in below example to look better.
> 
> 
>         ret = max77620_reg_update(chip->dev, MAX77620_PWR_SLAVE,
> -               MAX77620_REG_ONOFFCNFG2, MAX77620_ONOFFCNFG2_WK_EN0,
> -               MAX77620_ONOFFCNFG2_WK_EN0);
> +                       MAX77620_REG_ONOFFCNFG2, MAX77620_ONOFFCNFG2_WK_EN0,
> +                       MAX77620_ONOFFCNFG2_WK_EN0);
> 
> 

You should probably use checkpatch.pl --strict, it requires that you
align on the open parenthesis.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com