Re: [PATCH v4 05/11] of: earlycon: Initialize port fields from DT properties

[Peter Hurley]

On 01/12/2016 03:49 PM, Rob Herring wrote:
> On Tue, Jan 12, 2016 at 1:41 PM, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote:
>> Read the optional "reg-offset", "reg-shift", "reg-io-width" and endianness
>> properties and initialize the respective struct uart_port field if found.
>>
>> NB: These bindings are common to several drivers and the values merely
>> indicate the default value; the registering earlycon setup() method can
>> simply override the values if required.
>>
>> Signed-off-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
>> ---
> 
>> diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c
>> index 7509ee34d..03eac4a 100644
>> --- a/drivers/tty/serial/earlycon.c
>> +++ b/drivers/tty/serial/earlycon.c
>> @@ -20,6 +20,10 @@
>>  #include <linux/serial_core.h>
>>  #include <linux/sizes.h>
>>
>> +#ifdef CONFIG_OF_EARLY_FLATTREE
>> +#include <linux/of_fdt.h>
>> +#endif
> 
> I think you don't need the ifdef around this.
> 
>> +
>>  #ifdef CONFIG_FIX_EARLYCON_MEM
>>  #include <asm/fixmap.h>
>>  #endif

Ok, will take care of that.