Re: [PATCH v2 2/2] powercap/rapl: reduce ipi calls

From: Borislav Petkov
Date: Wed Jan 13 2016 - 11:36:30 EST


On Wed, Jan 13, 2016 at 08:21:13AM -0800, Jacob Pan wrote:
> Thanks for bring this out. I didn't mean to ignore. I thought my point
> was stated in the commit message there was no point of going back and
> forth. Read-Modify-Write is quite common, not just for RAPL could be
> used by future code. Sorry if I wasn't clear.

But it also shows that it doesn't suffice for all your needs. So why add
it?

You can much better define your own functions which do all the MSR
handling you require and call them with smp_call_function_*.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.