Re: [PATCH 1/4] arm: Fix wrong bounds check.

From: Laura Abbott
Date: Mon Jan 25 2016 - 13:37:48 EST


On 01/23/2016 07:05 AM, mika.penttila@xxxxxxxxxxxx wrote:
From: Mika Penttilà <mika.penttila@xxxxxxxxxxxx>

Not related to this oops, but while at it, fix incorrect bounds check.

Signed-off-by: Mika Penttilà mika.penttila@xxxxxxxxxxxx

---
arch/arm/mm/pageattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mm/pageattr.c b/arch/arm/mm/pageattr.c
index cf30daf..be7fe4b 100644
--- a/arch/arm/mm/pageattr.c
+++ b/arch/arm/mm/pageattr.c
@@ -52,7 +52,7 @@ static int change_memory_common(unsigned long addr, int numpages,
if (start < MODULES_VADDR || start >= MODULES_END)
return -EINVAL;

- if (end < MODULES_VADDR || start >= MODULES_END)
+ if (end < MODULES_VADDR || end >= MODULES_END)
return -EINVAL;

data.set_mask = set_mask;


This has been submitted a few times before, not sure if it is pending
in Russell's patch tracker or nobody has actually submitted it to the
patch tracker.

Russell, is this pending somewhere already?

Thanks,
Laura