Re: [PATCH 2/8] radix tree test harness

From: Andrew Morton
Date: Tue Jan 26 2016 - 18:44:45 EST


On Tue, 19 Jan 2016 09:25:27 -0500 Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx> wrote:

> From: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>
>
> This code is mostly from Andrew Morton; tarball downloaded
> from http://ozlabs.org/~akpm/rtth.tar.gz with sha1sum
> 0ce679db9ec047296b5d1ff7a1dfaa03a7bef1bd
>
> Some small modifications were necessary to the test harness to fix the
> build with the current Linux source code.
>
> I also made minor modifications to automatically test the radix-tree.c
> and radix-tree.h files that are in the current source tree, as opposed
> to a copied and slightly modified version. I am sure more could be
> done to tidy up the harness, as well as adding more tests.
>
> ...
>
> diff --git a/tools/testing/radix-tree/linux/radix-tree.h b/tools/testing/radix-tree/linux/radix-tree.h
> new file mode 120000
> index 0000000..1e6f41f
> --- /dev/null
> +++ b/tools/testing/radix-tree/linux/radix-tree.h
> @@ -0,0 +1 @@
> +../../../../include/linux/radix-tree.h
> \ No newline at end of file

glumpf. My tools have always had trouble with symlinks - patch(1)
seems to handle them OK but diff(1) screws things up. I've had one go
at using git to replace patch/diff but it was a fail.

Am presently too lazy to have attempt #2 so I think I'll just do

--- /dev/null
+++ a/tools/testing/radix-tree/linux/radix-tree.h
@@ -0,0 +1 @@
+#include "../../../../include/linux/radix-tree.h"