Re: [PATCH 2/8] radix tree test harness

From: Matthew Wilcox
Date: Tue Jan 26 2016 - 22:21:03 EST


On Tue, Jan 26, 2016 at 03:44:38PM -0800, Andrew Morton wrote:
> > diff --git a/tools/testing/radix-tree/linux/radix-tree.h b/tools/testing/radix-tree/linux/radix-tree.h
> > new file mode 120000
> > index 0000000..1e6f41f
> > --- /dev/null
> > +++ b/tools/testing/radix-tree/linux/radix-tree.h
> > @@ -0,0 +1 @@
> > +../../../../include/linux/radix-tree.h
> > \ No newline at end of file
>
> glumpf. My tools have always had trouble with symlinks - patch(1)
> seems to handle them OK but diff(1) screws things up. I've had one go
> at using git to replace patch/diff but it was a fail.
>
> Am presently too lazy to have attempt #2 so I think I'll just do
>
> --- /dev/null
> +++ a/tools/testing/radix-tree/linux/radix-tree.h
> @@ -0,0 +1 @@
> +#include "../../../../include/linux/radix-tree.h"

Fine by me; I wasn't sure whether to do it as an include or a symlink.
I could have gone either way.