Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver
From: chenfeng
Date: Thu Jan 28 2016 - 04:49:25 EST
Hi Lee,
Thanks for your review!
There is one things need your confirm.
Please help to see it below.
On 2016/1/25 22:22, Lee Jones wrote:
> On Mon, 11 Jan 2016, Chen Feng wrote:
>
>> Add pmic mfd driver to support hisilicon hi665x.
[..]
>
>> +static const struct mfd_cell hi655x_pmic_devs[] = {
>> + { .name = "hi655x-regulator", },
>> +};
>
> What other devices are there?
>
Current the MFD PMIC driver only has regulator enable.
The RTC & Power-key are not in these patch sets.
They will be added later.
Will this be accepted?
>> +static const struct regmap_irq hi655x_irqs[] = {
>> + { .reg_offset = 0, .mask = OTMP_D1R_INT },