Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024

[Laxman Dewangan]

On Thursday 28 January 2016 03:34 PM, Linus Walleij wrote:
> On Tue, Jan 19, 2016 at 11:19 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
>
> > MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO pins
> > which also act as the special function in alternate mode. Also
> > there is configuration like push-pull, open drain, FPS timing
> > etc for these pins.
> >
> > Add pincontrol driver to configure these parameters through
> > pincontrol APIs.
> >
> > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> > Signed-off-by: Chaitanya Bandi <bandik@xxxxxxxxxx>
> Nice. This driver looks like a lot of hard work, but I think
> it's worth it.
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thank you very much for acknowledgement.

> I guess Lee will be merging this into the MTD tree.
>
> (I still had those comments on the DT bindings but this driver
> part looks fine.)
I have posted patch V5 for enhancing DT binding doc as suggested by you 
and Lee. Request you to help on review.

I am going to send V6 to separate out DT binding doc patch with the 
driver file which I did in V5 and so want to correct if there is any 
more pending on document enhancement.