Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning
From: Jes Sorensen
Date: Fri Jan 29 2016 - 13:00:45 EST
Bhaktipriya Shridhar <bhaktipriya96@xxxxxxxxx> writes:
> This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@xxxxxxxxx>
> ---
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index d28f29a..e8a16b9 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -2657,7 +2657,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da)
>
> dump_mgntframe23a(padapter, pmgntframe);
>
> - return;
> }
If you insist on pushing this rather unncessary change, please do it
properly, and remove the blank line before the return statement as well.
Jes