Re: [PATCH 2/3] arm64: dts: add the Alpine v2 EVP
From: Antoine Tenart
Date: Mon Feb 08 2016 - 06:01:39 EST
Hi Mark,
On Mon, Feb 08, 2016 at 10:51:05AM +0000, Mark Rutland wrote:
>
> > + chosen {
> > + stdout-path = "console0:115200n8";
> > + };
>
> There is no console0 alias, so this cannot work.
>
> Did you mean serial0?
Oops... Yes, I meant serial0. I'll fix this.
> [...]
>
> > + aliases {
> > + serial0 = &uart0;
> > + serial1 = &uart1;
> > + serial2 = &uart2;
> > + serial3 = &uart3;
> > + };
>
> [...]
>
> > + psci {
> > + compatible = "arm,psci-0.2", "arm,psci";
> > + method = "smc";
> > + cpu_on = <0x84000003>;
> > + };
>
> If you have PSCI 0.2, the cpu_on ID (and all other mandatory function
> IDs) are implicit.
>
> If you want to have "arm,psci" as a fallback, then please add the IDs
> for functions mandatory in PSCI 0.2 which existed in the "arm,psci"
> binding. Otherwise, drop "arm,psci" from the compatible list, along
> with the cpu_on function ID.
OK. I'll make some tests and update.
Thanks or the review!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature