Re: [PATCH V4 12/23] x86, ia64, pci: Remove ACPI companion device from platform specific data.

From: Tomasz Nowicki
Date: Wed Feb 10 2016 - 16:21:25 EST


On 02/09/2016 06:28 PM, Lorenzo Pieralisi wrote:
This patch has to be squashed with the previous one otherwise it
has bisectability issues (ie the previous patch passes the parent
to the pci_create_root_bus() call so, without this patch applied,
the companion initialization would fail).
I do not think so. The previous patch passes the parent to the pci_create_root_bus(), indeed, so pci_create_root_bus() set companion device before calling pcibios_root_bridge_prepare() (for both cases x86 and ia64). In turn, pcibios_root_bridge_prepare() will do nothing, since bridge->dev.parent != NULL. After all, pcibios_root_bridge_prepare() is dead code.

Other than that:

Reviewed-by: Lorenzo Pieralisi<lorenzo.pieralisi@xxxxxxx>
Thanks!

Tomasz