Re: [PATCH v5 05/10] Input: synaptics-rmi4: Add device tree support for 2d sensors and F11

[Andrew Duggan]

On 02/12/2016 07:47 AM, Rob Herring wrote:
> On Wed, Feb 10, 2016 at 02:24:34PM -0800, Andrew Duggan wrote:
> > 2D sensors have several parameter which can be set in the platform data.
> > This patch adds support for getting those values from devicetree.
> >
> > Signed-off-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx>
> > ---
> >   .../bindings/input/rmi4/rmi_2d_sensor.txt          |  56 +++++++++++
> >   .../bindings/input/touchscreen/touchscreen.txt     |   2 +
> >   drivers/input/rmi4/rmi_2d_sensor.c                 | 108 +++++++++++++++++++++
> >   drivers/input/rmi4/rmi_2d_sensor.h                 |   3 +
> >   drivers/input/rmi4/rmi_f11.c                       |   7 +-
> >   5 files changed, 175 insertions(+), 1 deletion(-)
> >   create mode 100644 Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> [...]
>
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
> > index ac23caf..d6674de 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
> > @@ -18,6 +18,8 @@ Optional properties for Touchscreens:
> >    - touchscreen-inverted-y	: Y axis is inverted (boolean)
> >    - touchscreen-swapped-x-y	: X and Y axis are swapped (boolean)
> >   				  Swapping is done after inverting the axis
> > + - touchscreen-mm-x		: horizontal length in mm of the touchscreen
> > + - touchscreen-mm-y		: vertical length in mm of the touchscreen
> As I mentioned on v3, put the units on the end.

Oh sorry! I see you did mention that in v3 and I must have missed it.

Thanks,
Andrew

> Rob