[PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore

From: Anand Moon
Date: Thu Feb 18 2016 - 12:22:19 EST


From: Anand Moon <linux.amoon@xxxxxxxxx>

pl330_tasklet tasklet uses the same spinlock pch->lock for safe IRQ locking.
It's safe to initialize pl330_tasklet tasklet after release of the locking.

Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
---
drivers/dma/pl330.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 17ee758..df2cab1 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2091,10 +2091,10 @@ static int pl330_alloc_chan_resources(struct dma_chan *chan)
return -ENOMEM;
}

- tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch);
-
spin_unlock_irqrestore(&pch->lock, flags);

+ tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch);
+
return 1;
}

--
1.9.1