Re: [PATCH 5/5] x86/mbm: Add support for MBM counter overflow handling

[Thomas Gleixner]

On Wed, 10 Feb 2016, Vikas Shivappa wrote:
> +static enum hrtimer_restart mbm_hrtimer_handle(struct hrtimer *hrtimer)
> +{
> +	if (list_empty(&cache_groups))
> +		goto out;
> +
> +	list_for_each_entry(iter, &cache_groups, hw.cqm_groups_entry) {

....

> +		}
> +	}
> +
> +out:
> +	raw_spin_unlock_irqrestore(&cache_lock, flags);
> +	mutex_unlock(&cache_mutex);
> +
> +	hrtimer_forward_now(hrtimer, ms_to_ktime(MBM_CTR_OVERFLOW_TIME));
> +
> +	return HRTIMER_RESTART;

Why is that timer restarted if cache_groups is empty?

Thanks,

	tglx