Re: [PATCH v5 08/20] kthread: Allow to cancel kthread work

From: Petr Mladek
Date: Wed Feb 24 2016 - 11:18:14 EST


On Tue 2016-02-23 00:50:22, kbuild test robot wrote:
> Hi Petr,
>
> [auto build test WARNING on soc-thermal/next]
> [also build test WARNING on v4.5-rc5 next-20160222]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Petr-Mladek/kthread-Use-kthread-worker-API-more-widely/20160222-230250
> base: https://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal next
> reproduce: make htmldocs
>
> All warnings (new ones prefixed by >>):
>
> include/linux/init.h:1: warning: no structured comments found
> kernel/kthread.c:860: warning: No description found for parameter 'dwork'
> kernel/kthread.c:860: warning: No description found for parameter 'delay'
> kernel/kthread.c:860: warning: Excess function parameter 'work' description in 'queue_delayed_kthread_work'
> >> kernel/kthread.c:1012: warning: bad line:
> kernel/sys.c:1: warning: no structured comments found
> drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found

> vim +1012 kernel/kthread.c
> 1001
> 1002 /**
> 1003 * cancel_kthread_work_sync - cancel a kthread work and wait for it to finish
> 1004 * @work: the kthread work to cancel
> 1005 *
> 1006 * Cancel @work and wait for its execution to finish. This function
> 1007 * can be used even if the work re-queues itself. On return from this
> 1008 * function, @work is guaranteed to be not pending or executing on any CPU.
> 1009 *
> 1010 * cancel_kthread_work_sync(&delayed_work->work) must not be used for
> 1011 * delayed_work's. Use cancel_delayed_kthread_work_sync() instead.
> > 1012
> 1013 * The caller must ensure that the worker on which @work was last
> 1014 * queued can't be destroyed before this function returns.
> 1015 *

Ups, there was missing an asterisk. Please, find the fixed patch
below.