Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error

From: Aravind Gopalakrishnan
Date: Wed Feb 24 2016 - 13:07:12 EST


On 2/24/2016 5:37 AM, Borislav Petkov wrote:
On Tue, Feb 23, 2016 at 05:02:40PM -0600, Aravind Gopalakrishnan wrote:
On 2/23/16 6:11 AM, Borislav Petkov wrote:
On Tue, Feb 16, 2016 at 03:45:10PM -0600, Aravind Gopalakrishnan wrote:
/* AMD-specific bits */
-#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare an uncorrected error */
+#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare a deferred error */
/* uncorrected error, deferred exception */

sounds better to me.
Hmm. Well, Deferred error is a separate class of error by itself.
It's neither Corrected in HW nor is it Uncorrected like a MCE.
Let's consult the BKDG:

"Deferred: deferred error.


So it is an uncorrected error for which the raising of the error
exception was deferred until consumption.

Yep. Okay, I'll fix as you suggested.

If you feel "Uncorrected error, deferred error exception" won;t be
confusing, that's OK with me.
Why would it be confusing? It is describing exactly what a deferred
error is, albeit a bit too laconic but people can find the longer
description.


That's precisely it-
I thought I wasn't descriptive enough. But yeah, I guess I can include a reference to BKDG as well if anyone wants a detailed description.

Thanks,
-Aravind.