Re: [PATCH 04/50] pinctrl: bcm2835: Use devm_pinctrl_register() for pinctrl registration

From: Ray Jui
Date: Wed Feb 24 2016 - 13:28:10 EST




On 2/24/2016 5:15 AM, Laxman Dewangan wrote:
Use devm_pinctrl_register() for pin control registration.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
Cc: Ray Jui <rjui@xxxxxxxxxxxx>
---
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 0f5997c..25bc4a2 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -1027,7 +1027,7 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev)
return err;
}

- pc->pctl_dev = pinctrl_register(&bcm2835_pinctrl_desc, dev, pc);
+ pc->pctl_dev = devm_pinctrl_register(dev, &bcm2835_pinctrl_desc, pc);
if (IS_ERR(pc->pctl_dev)) {
gpiochip_remove(&pc->gpio_chip);
return PTR_ERR(pc->pctl_dev);
@@ -1045,7 +1045,6 @@ static int bcm2835_pinctrl_remove(struct platform_device *pdev)
{
struct bcm2835_pinctrl *pc = platform_get_drvdata(pdev);

- pinctrl_unregister(pc->pctl_dev);
gpiochip_remove(&pc->gpio_chip);

return 0;


Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>

Thanks!

Ray