Re: [PATCH 12/15] ACPICA: ACPI 6.1: Add full support for this version of ACPI spec
From: Rafael J. Wysocki
Date: Wed Feb 24 2016 - 18:17:18 EST
Hi Bob,
On Wednesday, February 24, 2016 05:39:14 PM Moore, Robert wrote:
>
> > There are few things I see missing in this patch in your updates made to
> > actbl1.h, I list them below:
> >
> > 1) Adding time stamp as you did breaks backwards compatibility (something
> > we discovered during our testing). We tried to remedy this by adding a
> > new version of the acpi_hest_generic_data structure. Note that we named
> > it v3 to reflect this was the updated version number in ACPI 6.1. (see
> > https://lkml.org/lkml/2016/2/5/549)
>
> I used V300 in case there is ever some other 3xx version.
>
> Plus, I made a full struct for the V300 case.
>
> >
> > 2) Missing definition of generic error data validation bits, needed to
> > determine whether or not field being read are valid or not (see
> > https://lkml.org/lkml/2016/2/5/549)
>
> Done.
>
> >
> > 3) Need to extend acpi_hest_notify_types to add GPIO, SEA, SEI, and GSIV
> > (see https://lkml.org/lkml/2016/2/5/545)
>
> Done.
OK
Should I expect an update of the $subject patch, then, or will there be a new
patch on top of it?
Thanks,
Rafael