Re: [PATCH v3 2/2] gpio: designware: add gpio-signaled acpi events support for power button

[Jiang Qiu]

å 2016/2/24 21:49, Andy Shevchenko åé:
> On Wed, Feb 24, 2016 at 2:33 PM, qiujiang <qiujiang@xxxxxxxxxx> wrote:
>> This patch modifies the designware gpio controller driver to
>> support the gpio-signaled acpi events. This is used for power
>> button on hisilicon D02 board(an arm64 platform).
> 
>> @@ -434,6 +436,10 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
>>         else
>>                 port->is_registered = true;
>>
>> +       /* Add GPIO-signaled ACPI event support */
>> +       if (pp->irq)
>> +               acpi_gpiochip_request_interrupts(&(port->gc));
> 
> Redundant parens.
OK, fixed it in next version, thank you.
> 
>> @@ -447,7 +453,7 @@ static void dwapb_gpio_unregister(struct dwapb_gpio *gpio)
>>  }
>>
>>  static struct dwapb_platform_data *
>> -dwapb_gpio_get_pdata_of(struct device *dev)
>> +dwapb_gpio_get_pdata(struct device *dev)
>>  {
>>         struct fwnode_handle *fwnode;
>>         struct dwapb_platform_data *pdata;
>> @@ -455,9 +461,6 @@ dwapb_gpio_get_pdata_of(struct device *dev)
>>         int nports;
>>         int i;
>>
> 
>> -       if (!IS_ENABLED(CONFIG_OF_GPIO) || !(dev->of_node))
>> -               return ERR_PTR(-ENODEV);
>> -
> 
> I think it belongs to patch 1.
If these code remove to patch1, it will contain ACPI support and patch2
implement GPIO-signaled acpi events support only.

Maybe this patchset partition looks more clearly, I think.
> 
>> @@ -479,15 +482,13 @@ dwapb_gpio_get_pdata_of(struct device *dev)
>>
>>                 if (fwnode_property_read_u32(fwnode, "reg", &pp->idx) ||
>>                     pp->idx >= DWAPB_MAX_PORTS) {
>> -                       dev_err(dev, "missing/invalid port index for %s\n",
>> -                               to_of_node(fwnode)->full_name);
>> +                       dev_err(dev, "missing/invalid port index\n");
> 
> Ditto.
> 
>> -                       dev_info(dev, "failed to get number of gpios for %s\n",
>> -                                to_of_node(fwnode)->full_name);
>> +                       dev_info(dev, "failed to get number of gpios\n");
> 
> Ditto.
> 
>> @@ -495,7 +496,7 @@ dwapb_gpio_get_pdata_of(struct device *dev)
>>                  * Only port A can provide interrupts in all configurations of
>>                  * the IP.
>>                  */
>> -               if (pp->idx == 0 &&
>> +               if (dev->of_node && pp->idx == 0 &&
> 
> Why is it needed?
Different APIs was used to parse interrupt resource for DT and ACPI, a unified way
platform_get_irq looks like more resonable, I will fixed it in the next version.
> 
>