Re: [RFC PATCH 1/5] perf trace: Apply config options in '.perfconfig'

From: Arnaldo Carvalho de Melo
Date: Thu Feb 25 2016 - 07:50:55 EST


Em Thu, Feb 25, 2016 at 08:51:51AM +0000, Wang Nan escreveu:
> 'perf trace' doesn't read and apply options in ~/.perfconfig. If a BPF
> script is passed to 'perf trace --ev' and clang is not in $PATH,
> perf trace doesn't compile the script even clang-path is configured in
> ~/.perfconfig.
>
> This patch makes 'perf trace' read and apply default config options
> from that file.

Right, I wonder if we can't move this initialization to perf's main
instead of having to call this for each subcommand...

> Signed-off-by: Wang Nan <wangnan0@xxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Li Zefan <lizefan@xxxxxxxxxx>
> Cc: pi3orama@xxxxxxx
> ---
> tools/perf/builtin-trace.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 20916dd..6c52f3c 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -3108,6 +3108,8 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)
> goto out;
> }
>
> + perf_config(perf_default_config, NULL);
> +
> argc = parse_options_subcommand(argc, argv, trace_options, trace_subcommands,
> trace_usage, PARSE_OPT_STOP_AT_NON_OPTION);
>
> --
> 1.8.3.4