Re: [PATCH] mm: remove __GFP_NOFAIL is deprecated comment

[Michal Hocko]

On Thu 25-02-16 13:36:11, Nikolay Borisov wrote:
[...]
> > +		/*
> > +		 * We most definitely don't want callers attempting to
> > +		 * allocate greater than order-1 page units with __GFP_NOFAIL.
> > +		 */
> > +		WARN_ON_ONCE(unlikely(gfp_flags & __GFP_NOFAIL) && (order > 1));
> 
> WARN_ON_ONCE already includes an unlikely in its definition:
> http://lxr.free-electrons.com/source/include/asm-generic/bug.h#L109

OK, I just wanted to keep the condition untouched but you are right the
unlikely can be removed.

> Reviewed-by: Nikolay Borisov <kernel@xxxxxxxx>

Thanks!
---