RE: [PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell

From: Amitkumar Karwar
Date: Thu Feb 25 2016 - 09:49:13 EST


Hi Marcel,

> From: Marcel Holtmann [mailto:marcel@xxxxxxxxxxxx]
> Sent: Saturday, February 20, 2016 1:37 PM
> To: Amitkumar Karwar
> Cc: BlueZ development; Nishant Sarmukadam; linux-kernel@xxxxxxxxxxxxxxx;
> Cathy Luo; Ganapathi Bhat
> Subject: Re: [PATCH v2] Bluetooth: hci_uart: Support firmware download
> for Marvell
>
> Hi Amitkumar,
>
> > This patch implement firmware download feature for Marvell Bluetooth
> > devices. If firmware is already downloaded, it will skip downloading.
> >
> > Signed-off-by: Ganapathi Bhat <gbhat@xxxxxxxxxxx>
> > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> > ---
> > v2: Fixed compilation warning reported by kbuild test robot
> > ---

Thanks for your review.
We are able to resolve all your comments. We are now checking how can we avoid firmware and helper file name global variables and module parameters.

Regards,
Amitkumar