[report] invalid error code in do_register_con_driver() console

From: Dan Carpenter
Date: Thu Feb 25 2016 - 16:34:22 EST


Hi Jiri,

I'm getting the following static checker warning:

drivers/tty/vt/vt.c:3588 do_register_con_driver()
warn: missing error code here? 'csw->con_startup()' failed. 'retval' = '0'

drivers/tty/vt/vt.c
3582 if (retval)
3583 goto err;
3584
3585 desc = csw->con_startup();
3586
3587 if (!desc)
3588 goto err;
3589
3590 retval = -EINVAL;
3591

Probably, we could more the "retval = -EINVAL;" before the goto? I
don't think it's intentional?

regards,
dan carpenter