Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails

[Kuba Kicinski]

On 25 February 2016 18:24:27 GMT-05:00, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
>If the allocation of ivp fails the error handling attempts to
>free an uninitialized dma_buf; this data structure just contains
>garbage on the stack, so the freeing will cause issues when the
>urb, buf and dma fields are free'd. Fix this by not free'ing the
>dma_buf if the ivp allocation fails.
>
>Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

LGTM, thanks.