Re: [PATCH 2/2] device property: fix for a case of use-after-free

From: Heikki Krogerus
Date: Fri Feb 26 2016 - 05:36:55 EST


On Fri, Feb 26, 2016 at 10:04:34AM +0200, Heikki Krogerus wrote:
> On Mon, Feb 22, 2016 at 05:04:04PM +0000, Shevchenko, Andriy wrote:
> > Considering this, perhaps better solution is to convert last lines to
> >
> > if (!IS_ERR(fwnode) && is_pset_node(fwnode)) {
> >   set_secondary_fwnode(dev, NULL);
> >   pset_free_set(to_pset_node(fwnode));
> > }
>
> After some testing, this seems to work. I'll prepare v2 and use it.

Sorry, I was a bit too hasty with my answer. So that also does not
work in case the pset provides the fwnode.


Thanks,

--
heikki